docs: use feature(doc_cfg) instead of doc_auto_cfg #453
Conversation
The docs.rs builds were failing since feature(doc_auto_cfg) was replaced by feature(doc_cfg). fixes zip-rs#452
Summary of ChangesHello @abatkin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue preventing successful documentation builds on Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the crate's documentation attributes to fix a build failure on docs.rs. The change correctly replaces the deprecated doc_auto_cfg feature with the stable doc_cfg feature. This is a necessary update to align with recent changes in the Rust toolchain and ensures that the documentation for this crate can be built successfully. The change is correct and well-contained.
|
Thanks for this fix! It's currently blocked on #457, which in turn is blocked on RustCrypto/traits#2036. |
Pr0methean
added
the
waiting on another PR
|
Testing whether this can be merged on top of #458 instead. |
|
Would suggest getting this released sooner (rather than waiting for 7 to be complete). |
|
Kinda hard to use a library without docs. Any plans to make a release including this so people can upgrade to v6? |
|
Hi You have also some examples in |
5 participants
The docs.rs builds were failing since feature(doc_auto_cfg) was replaced by feature(doc_cfg).
fixes #452